soc/cores/video: fix framebuffer color output #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier patch fixed the swapped red and blue channels on the HDMI PHYs. This exposed the fact that the framebuffer readout was swapped too. The framebuffer readout is fixed by this patch to match the r5g6b5 and a8b8g8r8 color format definitions documented in the Linux kernel's simplefb driver and used by LiteX: https://www.kernel.org/doc/Documentation/devicetree/bindings/display/simple-framebuffer.txt This has been tested using 16 bit SDRAM in both supported color formats. Additionally the green color used by the video terminal is swapped. It now matches the color used by LiteX on Ubuntu's terminal, from which it was probably originally sourced.
|
Thanks @tpwrules, this should be good, but I'll do a test on hardware. (Since this could also be dependent of the DRAM configuration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier patch fixed the swapped red and blue channels on the HDMI PHYs. This exposed the fact that the framebuffer readout was swapped too.
The framebuffer readout is fixed by this patch to match the r5g6b5 and a8b8g8r8 color format definitions documented in the Linux kernel's simplefb driver and used by LiteX:
https://www.kernel.org/doc/Documentation/devicetree/bindings/display/simple-framebuffer.txt
This has been tested using 16 bit SDRAM in both supported color formats.
Additionally the green color used by the video terminal is swapped. It now matches the color used by LiteX on Ubuntu's terminal, from which it was probably originally sourced.